Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globally hide dom-{bind,if,repeat} elements with legacyOptmizations on #5548

Merged
merged 1 commit into from
May 30, 2019
Merged

Globally hide dom-{bind,if,repeat} elements with legacyOptmizations on #5548

merged 1 commit into from
May 30, 2019

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented May 24, 2019

Too many breaking tests internally to not hide them

@dfreedm
Globally hide dom-{bind,if,repeat} elements with legacyOptmizations on
43f57b1 
Too many breaking tests internally to not hide them
@dfreedm dfreedm requested a review from kevinpschaaf May 24, 2019 18:20
kevinpschaaf
kevinpschaaf reviewed May 28, 2019
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; perf testing on Edge shows improvement.

@dfreedm dfreedm merged commit 05231a0 into master May 30, 2019
@dfreedm dfreedm deleted the hide-template-controls-globally branch May 30, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

@sorvell sorvell Awaiting requested review from sorvell

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dfreedm @kevinpschaaf @googlebot